[MS Connector] Compute parents array for document upsertion #6233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipperolet
force-pushed
the
ms-parents
branch
from
5a8bfa4 to
560cc45
Compare
JulesBelveze
approved these changes
Jul 16, 2024
| }, | ||
| (connectorId, parentInternalId, startSyncTs) => | ||
| `microsoft-${connectorId}-parent-${parentInternalId}-syncms-${startSyncTs}`, | ||
| 10 * 60 * 1000 |
There was a problem hiding this comment.
nit: let's store it in a variable?
lasryaric
approved these changes
Jul 16, 2024
| @@ -117,14 +122,84 @@ export async function getSiteNodesToSync( | |||
| [] as MicrosoftNode[] | |||
| ); | |||
|
|
|||
| // for all folders, check if a parent folder or drive is already in the list, | |||
| // in which case remove it this can happen because when a user selects a | |||
There was a problem hiding this comment.
missing a . after "remove it".
| // Keeping them both in the sync list can result in various kinds of issues, | ||
| // e.g. if a child folder is synced before the parent, then the child folder's | ||
| // files' parents array will be incomplete, thus the need to prune the list | ||
| const nodesToSync = allNodes.filter( |
There was a problem hiding this comment.
This seems to be a O(N^2) loop, are we sure it's properly bounded?
Is there not a better way to do that?
There was a problem hiding this comment.
No prob here; max max a hundred of items (it's the user selection of folders), and the costly part is only run O(n) 👍
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
* comments on internal id for microsoft * exclude folders whose parents are already in sync list * parents implementation * clean * fix filter/async * review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/dust-tt/tasks/issues/1053
This PR adds computation of parents array when we upsert a document, allowing hierarchy selection in datasources actions for assistants to work. Additionally:
Risk & deploy
na (gated)