Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Agent_message does not load runIds anymore #6248

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

PopDaph
Copy link
Contributor

@PopDaph PopDaph commented Jul 16, 2024

Description

Task: https://github.com/dust-tt/tasks/issues/1061

Event agent_generation_success was in charge of setting the runIds.
We've stop yielding this event here: https://github.com/dust-tt/dust/pull/6169/files to use instead agent_message_success

This PR edits agent_message_success to attach the runId and be able to retrieve them and attach them to the agentMessage.

Risk

Will test on front-edge.
Can be rolled back.

Deploy Plan

Deploy front.

@PopDaph PopDaph requested a review from fontanierh July 16, 2024 13:43
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing 🙏

@PopDaph PopDaph merged commit b50ce48 into main Jul 16, 2024
6 checks passed
@PopDaph PopDaph deleted the fix-missing-runIds branch July 16, 2024 14:49
albandum pushed a commit that referenced this pull request Aug 28, 2024
* Fix Agent_message does not load runIds anymore

* Attach runIds directly to agent_message_success
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants