Builder: Action empty description error message only if user has submitted #6278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopDaph
force-pushed
the
builder-action-empty-desc
branch
from
650cf5a to
1ed02ea
Compare
PopDaph
force-pushed
the
builder-action-empty-desc
branch
from
1ed02ea to
76365b7
Compare
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
…itted (#6278) * Builder: Action empty description error message only if user has submitted * Actually since we enable save we need to handle errors for all fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when we open an action the error message "Description cannot be empty." is immediately displayed.
Task: https://github.com/dust-tt/tasks/issues/1070
This PR edits the AssistantBuilder so that we display this error only if the users tries to submit. Meaning we enable the save button but display an error if action is not valid.
Deployed to front-edge if you want to check the behavior 🙏🏻
Risk
Can be rolled back.
Deploy Plan
Deploy front.