[MS connector] Tweaks on incremental sync #6357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesBelveze
approved these changes
Jul 20, 2024
| ? null | ||
| : getParentReferenceInternalId(driveItem.parentReference); | ||
|
|
||
| // check if we |
There was a problem hiding this comment.
nit: missing something here I guess 😺
| dataSourceConfig: DataSourceConfig; | ||
| startSyncTs: number; | ||
| }) { | ||
| const children = await folder.fetchChildren(); |
There was a problem hiding this comment.
nit: I added an optional argument where you can pass a list of nodeTypes to filter on. Not gonna change much but you could do:
const children = await folder.fetchChildren(["file", "folder"]);There was a problem hiding this comment.
In that case, i'd rather fetch all children and have the code err if they're not files or folders --- since it should not happen (not sure i'm clear 😅 happy to clarify irl)
philipperolet
force-pushed
the
ms-incrsync2
branch
from
4baa156 to
b35645a
Compare
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
* fix: parentInternalId should be null by default, and always null for roots * handle 410 require resync error * update parents on folder movement * fix movement detection * lint * clean com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few remaining issues in incremental sync:
Fixes #6289
Risk
na