Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth: GoogleDrive connector dual-flow + front gating #6373

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Jul 21, 2024

Description

  • Implenents dual support for Nango and oauth for GoogleDrive
  • Gate google_drive for oauth setup in front.
  • Remove token revocation on delete since it requires refresh_token and we don't use webhooks anymore

Test to be run in local dev:

  • create + full sync
  • update
  • delete

Risk

Low

Deploy Plan

  • deploy front
  • deploy connectors

@spolu spolu requested review from fontanierh and flvndvd and removed request for fontanierh July 21, 2024 21:30
Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comment is addressed.

connectors/src/connectors/google_drive/temporal/utils.ts Outdated Show resolved Hide resolved
@spolu spolu force-pushed the spolu-google_drive_dual_flow branch from 5ad8367 to df9f868 Compare July 22, 2024 07:26
@spolu
Copy link
Contributor Author

spolu commented Jul 22, 2024

All tested in dev 👍

@spolu spolu merged commit 0adfd85 into main Jul 22, 2024
8 checks passed
@spolu spolu deleted the spolu-google_drive_dual_flow branch July 22, 2024 07:37
albandum pushed a commit that referenced this pull request Aug 28, 2024
* GoogleDrive connector: dual-flow oauth/nango

* oauth: gate google_drive

* fix

* Update connectors/src/connectors/google_drive/temporal/utils.ts

Co-authored-by: Flavien David <[email protected]>

---------

Co-authored-by: Flavien David <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants