move viz at the top, remove tabs and improve dust app #6521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flvndvd
approved these changes
Jul 25, 2024
| @@ -135,8 +135,8 @@ export function VisualizationActionIframe({ | |||
| isStreaming: boolean; | |||
| onRetry: () => void; | |||
| }) { | |||
| const [activeTab, setActiveTab] = useState<"code" | "runtime">("code"); | |||
| const [tabManuallyChanged, setTabManuallyChanged] = useState(false); | |||
| // const [activeTab, setActiveTab] = useState<"code" | "runtime">("code"); | |||
front/components/assistant/conversation/actions/VisualizationActionIframe.tsx
Outdated
Show resolved
Hide resolved
fontanierh
force-pushed
the
enh/viz-at-the-top
branch
from
071ac7f to
7bc1990
Compare
flvndvd
approved these changes
Jul 25, 2024
front/components/assistant/conversation/actions/VisualizationActionIframe.tsx
Outdated
Show resolved
Hide resolved
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
* move viz at the top, remove tabs and improve dust app * weird hack * increase max h * r --------- Co-authored-by: Henry Fontanier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Risk
Deploy Plan