[chore] - sparkle: enhance Tree component
#6606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
These changes introduce a couple of breaking changes that are fixed in #6607 |
- Increment package version for release of new features or fixes - Ensure consistency across package-lock.json and package.json files
fontanierh
approved these changes
Jul 31, 2024
sparkle/src/components/Tree.tsx
Outdated
| @@ -49,13 +49,15 @@ interface TreeItemProps { | |||
| label?: string; | |||
| type?: "node" | "item" | "leaf"; | |||
| variant?: "file" | "folder" | "database" | "channel"; | |||
| visual?: React.ReactNode; | |||
| size?: "sm" | "md"; | |||
| visual?: ComponentType<{ className?: string }>; | |||
There was a problem hiding this comment.
@fontanierh Yeah I don't know either, this is actually what breaks in #6607.
There was a problem hiding this comment.
Dunno what was the rational behind but it could be to render all visuals as Icon and control the size?
added 2 commits
July 31, 2024 17:18
…isuals - Changed the `visual` prop type from `ComponentType` to `React.ReactNode` to allow for direct JSX elements - Updated `Tree.stories.tsx` to pass JSX elements directly instead of as references to components
…mponent - Cleaned up Tree.tsx by removing an unused import to streamline the component's dependencies
|
FYI @fontanierh moved back to |
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
* Updating tree to accomodate to bigger tree element sizes * Changing copy * [sparkle] - feature: bump version to 0.2.196 - Increment package version for release of new features or fixes - Ensure consistency across package-lock.json and package.json files * [sparkle] - refactor: update Tree component to accept ReactNode for visuals - Changed the `visual` prop type from `ComponentType` to `React.ReactNode` to allow for direct JSX elements - Updated `Tree.stories.tsx` to pass JSX elements directly instead of as references to components * [sparkle] - refactor: remove unused ComponentType import from Tree component - Cleaned up Tree.tsx by removing an unused import to streamline the component's dependencies --------- Co-authored-by: Edouard Wautier <[email protected]> Co-authored-by: Jules <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the Tree component in Sparkle to accommodate larger tree element sizes and improve its flexibility. The changes include:
All tributes to @Duncid I just tested it and fixed the breaking front issues in #6607
Risk
Breaking UX
Deploy Plan