enh: make viz responsive, remove extra renders, handle err in main window #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flvndvd
reviewed
Aug 1, 2024
front/components/assistant/conversation/actions/VisualizationActionIframe.tsx
Outdated
Show resolved
Hide resolved
front/components/assistant/conversation/actions/VisualizationActionIframe.tsx
Outdated
Show resolved
Hide resolved
| @@ -202,7 +201,9 @@ export function VisualizationActionIframe({ | |||
| <div | |||
| className={classNames( | |||
| "transition-height relative w-full overflow-hidden duration-500 ease-in-out", | |||
| codeFullyGenerated ? "min-h-96" : "" | |||
| codeFullyGenerated && !errored ? "min-h-96" : "", | |||
There was a problem hiding this comment.
🤔 Don't we want the min height only when we have an error?
There was a problem hiding this comment.
(explained on slack)
| style={{ | ||
| height: !errored ? `${contentHeight}px` : "100%", | ||
| minHeight: !errored ? "96" : undefined, | ||
| maxHeight: "60vh", |
There was a problem hiding this comment.
No we need this actually
There was a problem hiding this comment.
It's already below set with tailwind, why do we need to duplicate?
| @@ -28,65 +26,14 @@ export class ErrorBoundary extends React.Component< | |||
|
|
|||
| componentDidCatch(error: unknown) { | |||
| this.setState({ hasError: true, error }); | |||
| this.props.onErrored(); | |||
There was a problem hiding this comment.
Why not passing the error message as we use to?
There was a problem hiding this comment.
We don't do anything with it yet
There was a problem hiding this comment.
So we'll pass it when we need it
added 4 commits
August 1, 2024 18:50
flvndvd
approved these changes
Aug 1, 2024
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
…ndow (#6629) * enh: improve viz responsiveness, remove extra renders, handle error in main * mark last viz as complete on agent message success * naming * nit * remove outdated comment * r --------- Co-authored-by: Henry Fontanier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setErroredcross-doc call to set error state on parent window)onLoadand not relying on iframe to display the error)After this PR, we can release viz
Risk
N/A
Deploy Plan