Upg: execute lint in pre-commit hook if DUST_LINT_ON_COMMIT=1 #6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flvndvd
approved these changes
Aug 9, 2024
.husky/pre-commit
Outdated
| @@ -10,6 +10,29 @@ if [ "$current_branch" = "main" ]; then | |||
| fi | |||
| fi | |||
|
|
|||
| # Allow commit | |||
| exit 0 | |||
| # If env var viDUST_LINT_ON_COMMIT = 1, run the linter | |||
There was a problem hiding this comment.
Suggested change
| # If env var viDUST_LINT_ON_COMMIT = 1, run the linter | |
| # If env var DUST_LINT_ON_COMMIT = 1, run the linter |
| for directory in "${directories[@]}"; do | ||
| if git diff --cached --name-only | grep -qE "^$directory/"; then | ||
| # Run the linter on root_path concatenated with the directory | ||
| if ! npm run lint --prefix $root_path/$directory; then |
There was a problem hiding this comment.
Usually people go with https://www.npmjs.com/package/lint-staged that pretty output linter errors.
There was a problem hiding this comment.
Thanks for the pointer, i'll keep the PR as it to avoid distracting myself too much :)
Fraggle
force-pushed
the
sflory-optin-for-linter-in-precommit-hook
branch
from
fcaaf6d to
176592a
Compare
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lint on pre-commit if DUST_LINT_ON_COMMIT=1.
Risk
None
Deploy Plan
None