Add system vault navigation #6750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesBelveze
approved these changes
Aug 13, 2024
| const SystemVaultMenu = () => { | ||
| // TODO(Groups UI) Implement system vault menu. | ||
| return <></>; | ||
| const SYSTEM_VAULTS_ITEMS = [ |
There was a problem hiding this comment.
Should we move this to types? Feel like we are gonna need this in other places
There was a problem hiding this comment.
This is specifically for menu rendering so I'd keep it close to the implementation. What other places do you have in mind?
There was a problem hiding this comment.
The company data screen?
| owner: LightWorkspaceType; | ||
| vault: VaultType; | ||
| item: DataSourceOrViewInfo; | ||
| viewType: "data_sources" | "data_source_views"; |
There was a problem hiding this comment.
Should we move the DataSourceOrView type from swr to types and reuse it here?
There was a problem hiding this comment.
Indeed this one could live in types. Let me move it.
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
* Add system vault navigation * Move DataSourceOrView to type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #6745.
This PR adds the navigation for the system vault based on design from here.
Risk
Deploy Plan