Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] Implement screenshot downloader for recharts-based graphs #6848

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

alexeyeryshev
Copy link

@alexeyeryshev alexeyeryshev commented Aug 21, 2024

Description

This PR adds a button to the vizualization-powered graph generated with recharts if they can be exported as an SVG.
It works by adding a button to viz wrapper and using event source API to pass the Blob to the main dust frontend app.

The download button needs some love to style.

Screen.Recording.2024-08-21.at.17.31.40.mov

Risk

Safe to rollback.

Deploy Plan

  1. Deploy frotnend
  2. Use an assistant with viz enabled to verify the functionality
  3. Ask it to generate a simple graph with recharts, check for the download button and that it does what you expect it to.
  4. Ask it to generete a todo app - the download button shouldn't be shown.

@alexeyeryshev alexeyeryshev changed the title implement screenshot downloader Implement screenshot downloader for recharts-based graphs Aug 21, 2024
@alexeyeryshev alexeyeryshev changed the title Implement screenshot downloader for recharts-based graphs [front] Implement screenshot downloader for recharts-based graphs Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant