[Sparkle] Breadcrumbs component #6934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description --- Moves the Breadcrumbs component to sparkle as part of #6906 Risk --- na - component is added but not used & the former is not deleted (this comes in a follow-up PR) Deploy --- publish sparkle
|
cc @Duncid |
|
Thanks @philipperolet ! |
tdraier
reviewed
Aug 27, 2024
| @@ -0,0 +1,52 @@ | |||
| import Link from "next/link"; | |||
There was a problem hiding this comment.
You can't use next/link in sparkle (no next dependency here). Maybe we should pass the component to render for link as a prop ?
There was a problem hiding this comment.
I see, thanks for noticing (next dependency was installed locally despite not being in package.json)
Is there an isssue with adding the dependency? Link seems pretty standard, being able to use it in sparkle without a hack would be good
philipperolet
force-pushed
the
vaults-bc-sparkle
branch
from
c11b306 to
a0ec0c9
Compare
tdraier
approved these changes
Aug 27, 2024
philipperolet
added a commit
that referenced
this pull request
Aug 27, 2024
Description --- Follow-up of #6934 Risk --- low Deploy --- front
philipperolet
added a commit
that referenced
this pull request
Aug 27, 2024
Description --- Follow-up of #6934 Risk --- low Deploy --- front
philipperolet
added a commit
that referenced
this pull request
Aug 27, 2024
* [Vaults UI] Bump sparkle + use new Breadcrumbs component Description --- Follow-up of #6934 Risk --- low Deploy --- front * fix
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
* [Sparkle] Breadcrumbs component Description --- Moves the Breadcrumbs component to sparkle as part of #6906 Risk --- na - component is added but not used & the former is not deleted (this comes in a follow-up PR) Deploy --- publish sparkle * clean * next tentative * next tentative plock * remove next after all * lint
albandum
pushed a commit
that referenced
this pull request
Aug 28, 2024
* [Vaults UI] Bump sparkle + use new Breadcrumbs component Description --- Follow-up of #6934 Risk --- low Deploy --- front * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the Breadcrumbs component to sparkle as part of #6906
This PR is a refactor but does not change functionality
Risk
na - component is added but not used & the former is not deleted (this comes in a follow-up PR)
Deploy
publish sparkle