Polishing Input, Area, Chip, Dropdown #8581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duncid
changed the title
- Abstract animated text background and text color variants into separate records for cleaner code structure - Use cva utility from `class-variance-authority` to manage TextArea component styles, introducing a more flexible and scalable approach to variant handling [sparkle] - fix: mark `isBusy` prop in `Chip` component as potentially undefined - Adjust typings for `isBusy` prop to correctly reflect its optional nature in the `Chip` component [sparkle] - refactor: introduce cva to refactor `TextArea` styles and variants - Consolidate `TextArea` styling and variant handling into a single cva call to improve readability and maintainability - Simplify the props destructuring in the `TextArea` component by relying on cva to handle default variants and classes
…verable` - Introduced `cva` for more scalable handling of className variations based on component variants - Replaced manual className construction with `cva` utility in `Hoverable` component for maintainability and readability improvements
JulesBelveze
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Polishing Input, Area, Chip, Dropdown
Risks
UI breaks