Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional fk to a conversion on datasource model #8655

Merged

Conversation

Fraggle
Copy link
Contributor

@Fraggle Fraggle commented Nov 15, 2024

Description

Add the foreign key on datasource model to conversation.

Risk

Temporary break prod if deployed without applying the migration first.

Deploy Plan

Merge, pull on dropbox, run migration, deploy front;

@Fraggle Fraggle requested review from spolu and fontanierh November 15, 2024 06:05
Copy link

github-actions bot commented Nov 15, 2024

Warnings
⚠️

Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from prodbox.

Generated by 🚫 dangerJS against e97264f

@Fraggle Fraggle added the migration-ack 📁 Label to acknowledge that a migration is required. label Nov 15, 2024
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fraggle Fraggle merged commit 7037e74 into main Nov 15, 2024
5 checks passed
@Fraggle Fraggle deleted the 1570-add-optional-fk-to-a-conversion-on-datasource-model branch November 15, 2024 07:45
Duncid pushed a commit that referenced this pull request Nov 15, 2024
* Add: foreign key on model

* Add: migration to add fk on datasource to conversation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants