[sparkle] Take focus in modal over close button #8772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which one ? (in my cas the close button was taking the focus) |
|
I mean, let's say I want to add focus on an |
If you have an explicit focus it should take over the simple tabIndex=1. I can also use tabIndex=32767 , which will come before the button but after any other positive tabIndex value. Do you have an example ? |
JulesBelveze
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://github.com/dust-tt/tasks/issues/1679
Description
Glitch appears when the close button takes focus on modal open. Give the focus to modal content instead (and remove the focus outline)
Risk
Deploy Plan