Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectors] Include isolated Categories in Zendesk article incremental sync #8908

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

aubin-tchoi
Copy link
Contributor

@aubin-tchoi aubin-tchoi commented Nov 26, 2024

Description

This PR fixes an edge case of the article incremental sync.

  • Previous behavior: article incremental sync run on brands whose Help Center is selected as a whole.
  • Problem: if a user selects single categories, these won't be kept up-to-date.
  • Fix: run the incremental sync on brands where at least one category is selected too (overkill but no incremental endpoint for Categories, a permission check is done when syncing the article).

Risk

Low.

Deploy Plan

  • Deploy connectors.

@aubin-tchoi aubin-tchoi self-assigned this Nov 26, 2024
@aubin-tchoi aubin-tchoi merged commit 438e456 into main Nov 26, 2024
4 checks passed
@aubin-tchoi aubin-tchoi deleted the zendesk/incremental-categories branch November 26, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants