[connectors] Fix(Zendesk) - users not found #8912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fontanierh
approved these changes
Nov 26, 2024
| @@ -427,7 +427,7 @@ export async function syncZendeskTicketBatchActivity({ | |||
| return { hasMore: false, nextLink: "" }; | |||
| } | |||
|
|
|||
| const users = await zendeskApiClient.users.list(); | |||
| const users = (await zendeskApiClient.users.list()) || []; | |||
There was a problem hiding this comment.
can .list() return undefined ?
There was a problem hiding this comment.
not in the types, yes in the actual implementation
albandum
reviewed
Nov 26, 2024
Comment on lines
+178
to
+187
| let author; | ||
| try { | ||
| author = users.find((user) => user.id === comment.author_id); | ||
| } catch (e) { | ||
| logger.warn( | ||
| { connectorId, e, ...loggerArgs }, | ||
| "[Zendesk] Error finding the author of a comment." | ||
| ); | ||
| author = null; | ||
| } |
There was a problem hiding this comment.
Suggested change
| let author; | |
| try { | |
| author = users.find((user) => user.id === comment.author_id); | |
| } catch (e) { | |
| logger.warn( | |
| { connectorId, e, ...loggerArgs }, | |
| "[Zendesk] Error finding the author of a comment." | |
| ); | |
| author = null; | |
| } | |
| const author = users?.find((user) => user?.id === comment?.author_id) || null; |
There was a problem hiding this comment.
that's not really what we're trying to fix with our try catch, will safely ignore for now
There was a problem hiding this comment.
Yeah actually not sure what this is supposed to do ?
There was a problem hiding this comment.
if there's an error here then it's a typescript error no ? there's no async at all
overmode
pushed a commit
that referenced
this pull request
Nov 27, 2024
* fix: fix issues with users not found by the SDK * fix: ignore issues with users not found by the SDK * 🔊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Risk
Low.
Deploy Plan