Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dropdown menu for conversation switching #8913

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Use dropdown menu for conversation switching #8913

merged 3 commits into from
Nov 26, 2024

Conversation

tdraier
Copy link
Contributor

@tdraier tdraier commented Nov 26, 2024 •
edited
Loading

fixes: #1697

Description

  • Replace conversations page by a dropdown.
  • Add conversations dropdown to conversation page
  • Fixed ConversationContainer to allow conversation switching
  • Use BarHeader in MainPage for buttons positions consistency
Screenshot 2024-11-26 at 16 07 55 Screenshot 2024-11-26 at 16 08 00 Screenshot 2024-11-26 at 16 50 12

Risk

Deploy Plan

@tdraier tdraier requested a review from PopDaph November 26, 2024 15:49
PopDaph
PopDaph approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@PopDaph PopDaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're just missing the chevron from the Figma but otherwise LGTM!

@tdraier tdraier merged commit 7de778e into main Nov 26, 2024
3 checks passed
@tdraier tdraier deleted the nav branch November 26, 2024 16:05
overmode pushed a commit that referenced this pull request Nov 27, 2024
@tdraier @overmode
[extension] Use dropdown menu for conversation switching (#8913)
94e5aa1 
* Use dropdown menu for conversation switching

* show selected conversation

* add chevron
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PopDaph PopDaph PopDaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdraier @PopDaph