enh(zendesk): lower concurrency to 3 for fetching ticket comments #8916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fontanierh
commented
Nov 26, 2024
| const res = await concurrentExecutor( | ||
| _.zip(tickets, comments), | ||
| async ([ticket, comments]) => { | ||
| if (!ticket || !comments) { |
There was a problem hiding this comment.
Both are technically | undefined as there's no typescript guarantee that both arrays are equal size
There was a problem hiding this comment.
OOC: do you prefer this over a map over the tickets to turn them into objects?
There was a problem hiding this comment.
Shorter like this but I don't have a strong opinion really
overmode
pushed a commit
that referenced
this pull request
Nov 27, 2024
) Co-authored-by: Henry Fontanier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're seeing EPIPE errors and timeouts.
I suspect it is related to the 10 concurrent requests to zendesk API for comments
Risk
N/A
Deploy Plan
Deploy connectors