[connectors] Cast known Zendesk errors #8917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fontanierh
approved these changes
Nov 26, 2024
| throw new ProviderWorkflowError( | ||
| "zendesk", | ||
| "Cursor expired", | ||
| "transient_upstream_activity_error", |
There was a problem hiding this comment.
Do we think this one will be transient ?
There was a problem hiding this comment.
actually this one is not transient, the activity here is part of a whole bunch of paginated activities that is transient as a whole
There was a problem hiding this comment.
should I just put a unhandled_internal_activity_error?
There was a problem hiding this comment.
Yeah because the retry is at the page level no ? So if we end up with this error we're stuck
There was a problem hiding this comment.
understood thanks 👍
overmode
pushed a commit
that referenced
this pull request
Nov 27, 2024
* add a few error types and checks * add `ZendeskCastKnownErrorsInterceptor` * add the interceptor to the worker * fix: remove redundant checks for known errors * fix: fix the error type of expired cursor errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Risk
Low.
Deploy Plan