Add: topic check for all deploys #8963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraggle
force-pushed
the
sflory-add-topic-check-for-all-deploys
branch
from
d6e6e1d to
b5d68cb
Compare
flvndvd
approved these changes
Nov 27, 2024
| @@ -100,4 +103,5 @@ runs: | |||
| thread_ts: "${{ inputs.thread_ts }}" | |||
| text: | | |||
| ❌ Build pipeline failed | |||
| Is blocked by channel topic: ${{ inputs.blocked || "n/a" }} | |||
There was a problem hiding this comment.
Nit: can we display this only if actually blocked?
There was a problem hiding this comment.
Sure : It you tell me how (don't want to spend an hour iterating again :))
There was a problem hiding this comment.
😅.
Haven't tested but I've seen stuff like this:
${{ inputs.blocked && format('Is blocked by channel topic: {0}', inputs.blocked) }}
Fraggle
force-pushed
the
sflory-add-topic-check-for-all-deploys
branch
from
96a2577 to
dae343e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply the channel topic check for all deploys.
Risk
Low (testing with front-edge)
Deploy Plan
Nothing