Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore previous behavior when posting a message #8965

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Fraggle
Copy link
Contributor

@Fraggle Fraggle commented Nov 27, 2024

Description

We want the message to disappear immediately from the input bar as before.

Risk

Low

Deploy Plan

Deploy front

@Fraggle Fraggle requested a review from flvndvd November 27, 2024 15:26
@spolu
Copy link
Contributor

spolu commented Nov 27, 2024

Ooooh why ooc? Liked the behavior.

Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flvndvd
Copy link
Contributor

flvndvd commented Nov 27, 2024

Ooooh why ooc? Liked the behavior.

It makes sense on the new conversation, but in an existing conversation it was breaking the magic of the optimistic UI ✨.

@spolu
Copy link
Contributor

spolu commented Nov 27, 2024

Makes sense. Should/can we keep it for new conversation?

@flvndvd
Copy link
Contributor

flvndvd commented Nov 27, 2024

This is the case in this PR.

@Fraggle
Copy link
Contributor Author

Fraggle commented Nov 27, 2024

Makes sense. Should/can we keep it for new conversation?

@spolu I kept the new behavior for new convo.

BTW, for replies, we need to enhance our current implementation as if the reply fails, the message (& files) will be lost. I was thinking of tackling it when I'll look into this

@Fraggle Fraggle merged commit 93c5666 into main Nov 27, 2024
3 checks passed
@Fraggle Fraggle deleted the 1709-fix-posting-a-message-should-empty-the-input-bar branch November 27, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants