Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(kw-search): title & mime in v1 tables upsert #8968

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

fontanierh
Copy link
Contributor

Description

Enforce that system API key callers of tables upsert public API are passing title & mime type.

Use default values for non-system API key callers (application/vnd.dust.table mime type, find title in tags or use the table name). We may decide to enforce passing title explicitly in the future.

Risk

critical path of tables upsert from public API (includes connectors)

Deploy Plan

Deploy front

Copy link

github-actions bot commented Nov 27, 2024

Warnings
⚠️

Files in **/api/v1/ have been modified and the PR has the documentation-ack label.
Don't forget to run npm run docs and use the Deploy OpenAPI Docs Github action to update https://docs.dust.tt/reference.

Generated by 🚫 dangerJS against 2c6bfd0

@fontanierh fontanierh added the documentation-ack Used to acknowledge that documentation is up-to-date with this PR label Nov 27, 2024
@fontanierh fontanierh merged commit 52716a5 into main Nov 27, 2024
5 checks passed
@fontanierh fontanierh deleted the enh/kw-search-title-mime-type-tables-upsert-v1 branch November 27, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-ack Used to acknowledge that documentation is up-to-date with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants