Rename core dust-api into core-api
#8970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fontanierh
approved these changes
Nov 27, 2024
| @@ -10,7 +10,7 @@ use axum::{ | |||
| routing::{delete, get, patch, post}, | |||
| Router, | |||
| }; | |||
| use futures::future::{try_join, try_join_all}; | |||
| use futures::future::try_join_all; | |||
There was a problem hiding this comment.
my bad. I would have expected CI to catch this 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We keep both binaries names + build around as we need a 2 step change with dust-infra
Risk
Large: if bootup fails. Hence why we keep both binaries for now
Deploy Plan
core(deploying should still use the old binary since the deploy is dust-infra driven)core(check that the deploy runs core-api now)core