New Metric Card Component #8987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good! A few feedbacks:
- it seems to as a very generic "card" right? Could we rename it to "Card" (or equivalent) instead of "MetricCard"?
- You have a problem in package.json, seems like you installed sparkle as a dependency of sparkle
- to make the API a tiny bit more friendly could we have a general component that instantiates the others, to be used like:
<MetricCard
size="xs"
isLoading={false}
title="blabla"
content={<div>test</div>}
/>Let me know if you need help with any of those!
| footer: "s-flex s-items-center s-gap-2", | ||
| loading: "s-flex s-items-center s-justify-start", | ||
| }, | ||
| } as const; |
There was a problem hiding this comment.
nit: not sure we need the as const here?
Comment on lines
45
to
55
| interface MetricCardRootProps | ||
| extends BaseProps, | ||
| VariantProps<typeof metricCardVariants> {} | ||
| interface MetricCardHeaderProps extends BaseProps {} | ||
| interface MetricCardTitleProps extends BaseProps {} | ||
| interface MetricCardSubtitleProps extends BaseProps {} | ||
| interface MetricCardContentProps extends Omit<BaseProps, "children"> { | ||
| children?: React.ReactNode; | ||
| isLoading?: boolean; | ||
| } | ||
| interface MetricCardFooterProps extends BaseProps {} |
There was a problem hiding this comment.
nit: we usually try to have the interface directly above its associated component
JulesBelveze
force-pushed
the
feature/sparkle-metric-card-clean
branch
from
63725ac to
38723e1
Compare
JulesBelveze
force-pushed
the
feature/sparkle-metric-card-clean
branch
from
0211220 to
a03e46f
Compare
- Standardize object and component formatting for consistency - Remove extraneous newlines and ensure proper newline at EOF in Card component files - Simplify export statements in components index file
- Updated package version in package-lock.json and package.json for new release - Changes include synchronization of the version across both files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New component to display metrics (already existing in the workspace but not as a component).
Risk
Deploy Plan
Merge
Deploy sparkle