Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connectors] fix(Zendesk) - fix the article garbage collection #9005

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[connectors] fix(Zendesk) - fix the article garbage collection #9005

merged 1 commit into from
Nov 28, 2024

Conversation

aubin-tchoi
Copy link
Contributor

Description

  • This PR aims at fixing the article garbage collection, which previously did not garbage collect anything.
  • It replaces the use of the lib node-zendesk with a regular fetch since the lib hides missing argument in a non-obvious way.

Risk

  • Low, will be monitored.

Deploy Plan

  • Deploy connectors.

@aubin-tchoi aubin-tchoi self-assigned this Nov 28, 2024
@aubin-tchoi aubin-tchoi merged commit b598f5c into main Nov 28, 2024
3 checks passed
@aubin-tchoi aubin-tchoi deleted the zendesk/fix-article-gc branch November 28, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PopDaph PopDaph PopDaph approved these changes

@fontanierh fontanierh Awaiting requested review from fontanierh

Assignees

@aubin-tchoi aubin-tchoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aubin-tchoi @PopDaph