Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size of images exposed to models #9027

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

Fraggle
Copy link
Contributor

@Fraggle Fraggle commented Nov 29, 2024

Description

Double the allowed image size exposed to models to allow them to see more details.
Depending on the image aspect ratio, it might be resized again on the provider end, adding a bit of latency.

Risk

Add latency, increase cost (a max size image is ~1k token).

Deploy Plan

Deploy front

@Fraggle Fraggle requested a review from spolu November 29, 2024 13:12
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but also deferring final review to @flvndvd

Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure to test on Anthropic as they only support base64 encodings and IIRC if you don't properly scale the request payload is just too big.

@Fraggle
Copy link
Contributor Author

Fraggle commented Nov 29, 2024

@flvndvd

image

Source image is 6000x8000

@Fraggle Fraggle merged commit dcbc79b into main Nov 29, 2024
3 checks passed
@Fraggle Fraggle deleted the sflory-increase-image-size branch November 29, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants