[front] - chore: upgrade sparkle #9150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies dependency - Update the @dust-tt/sparkle package to version 0.2.334-rc-1 - Remove the deprecated @tailwindcss/container-queries package following the update [front/components/spaces] - fix: adjust paddingRight in SpaceSideBarMenu - Add a paddingRight of 1 to the div in SpaceSideBarMenu for better spacing in UI elements
…cker component - Hide the default scroll bar in the assistant picker dropdown - Include a custom ScrollBar component for better UI consistency [front] - refactor: update @dust-tt/sparkle package to new release candidate - Bump the version of the @dust-tt/sparkle package to incorporate latest changes and fixes
- Upgrade the @dust-tt/sparkle package from version 0.2.334-rc-2 to version 0.2.336 - Update package-lock.json to reflect the new version's resolved URL and integrity SHA
overmode
approved these changes
Dec 5, 2024
| @@ -81,7 +82,7 @@ export function AssistantPicker({ | |||
| }} | |||
| /> | |||
| <DropdownMenuSeparator /> | |||
| <ScrollArea className="border-1 -mb-1 -mt-1 h-[300px]"> | |||
| <ScrollArea className="h-[300px]" hideScrollBar> | |||
There was a problem hiding this comment.
This fixed height will show a blank space if there are not enough items, this should make it dynamic to content
radix-ui/primitives#2307 (comment)
- Changed ScrollArea to a flex column with a maximum height and automatic overflow-y to enhance user experience - ScrollBar is now hidden to provide a cleaner look in the AssistantPicker component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at bumping the sparkle version used in front to use those modifications: #9133
References:
Risk
Low
Deploy Plan
Deploy
front