-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New card deploy #9448
Merged
Merged
New card deploy #9448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesBelveze
force-pushed
the
newCardDeploy
branch
from
December 17, 2024 15:01
93f0512
to
e8df641
Compare
…he app - Renamed `CitationNew` related components to `Citation` for consistency - Removed the `MarkdownCitation.tsx` as its interface was no longer used - Replaced `CitationType` with inline conditionals and direct icon imports - Updated `@dust-tt/sparkle` to version `0.2.343-rc5` reflecting these citation changes - Removed unused `typeIcons` object, adapting citation calls to use the new icon method
- Simplify the `CitationIconType` by directly using a union type instead of an array constant mapping
…nent - Removed individual icon imports for various services and replaced with a generic document icon - Implemented a citation icon map to dynamically resolve icons based on document provider - Simplified makeDocumentCitation and makeWebsearchResultsCitation by integrating icon components directly
Duncid
force-pushed
the
newCardDeploy
branch
from
December 19, 2024 09:55
30fbe3c
to
f953bb9
Compare
JulesBelveze
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploying the new Cards and Sparkle 345
Risk
Breaking UI in: