Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New card deploy #9448

Merged
merged 19 commits into from
Dec 19, 2024
Merged

New card deploy #9448

merged 19 commits into from
Dec 19, 2024

Conversation

Duncid
Copy link
Contributor

@Duncid Duncid commented Dec 17, 2024

Description

Deploying the new Cards and Sparkle 345

Risk

Breaking UI in:

  • Citations
    • Citations inside a "tool inspection"
  • Attachements (Input Bar)
  • Attachement (Conversation Message)
  • Tools in Builder
    • LEGACY tool
  • Favorites (and all assistant display on Empty Convo screen)
  • Templates list

Duncid and others added 18 commits December 19, 2024 10:49
…he app

 - Renamed `CitationNew` related components to `Citation` for consistency
 - Removed the `MarkdownCitation.tsx` as its interface was no longer used
 - Replaced `CitationType` with inline conditionals and direct icon imports
 - Updated `@dust-tt/sparkle` to version `0.2.343-rc5` reflecting these citation changes
 - Removed unused `typeIcons` object, adapting citation calls to use the new icon method
 - Simplify the `CitationIconType` by directly using a union type instead of an array constant mapping
…nent

 - Removed individual icon imports for various services and replaced with a generic document icon
 - Implemented a citation icon map to dynamically resolve icons based on document provider
 - Simplified makeDocumentCitation and makeWebsearchResultsCitation by integrating icon components directly
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Duncid Duncid merged commit ac54577 into main Dec 19, 2024
7 checks passed
@Duncid Duncid deleted the newCardDeploy branch December 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants