Adding folder nodes mapping the Intercom hierarchy #9469
Conversation
overmode
changed the title
overmode
force-pushed
the
9158-kw-search-update-backfill-folders-for-intercom
branch
from
99917fb to
be8e198
Compare
connectors/migrations/20241219_backfill_intercom_data_source_folders.ts
Outdated
Show resolved
Hide resolved
connectors/migrations/20241219_backfill_intercom_data_source_folders.ts
Outdated
Show resolved
Hide resolved
connectors/migrations/20241219_backfill_intercom_data_source_folders.ts
Outdated
Show resolved
Hide resolved
connectors/src/connectors/intercom/lib/conversation_permissions.ts
Outdated
Show resolved
Hide resolved
connectors/src/connectors/intercom/lib/conversation_permissions.ts
Outdated
Show resolved
Hide resolved
connectors/src/connectors/intercom/lib/help_center_permissions.ts
Outdated
Show resolved
Hide resolved
connectors/src/connectors/intercom/lib/help_center_permissions.ts
Outdated
Show resolved
Hide resolved
connectors/src/connectors/intercom/lib/conversation_permissions.ts
Outdated
Show resolved
Hide resolved
… revoke and strategy.detroy
overmode
force-pushed
the
9158-kw-search-update-backfill-folders-for-intercom
branch
from
19315b4 to
77eb440
Compare
| // Add folder node for teams | ||
| await upsertIntercomTeamsFolderActivity({ | ||
| connectorId, | ||
| }); | ||
|
|
There was a problem hiding this comment.
we're in for a ride again @philipperolet :)
There was a problem hiding this comment.
intercom is webhook-based for the conversations
There was a problem hiding this comment.
oh wait actually we're good, I thiiink webhooks rely on non-temporal code
There was a problem hiding this comment.
I would guess we can stop all the workflows, deploy and resume them, which will trigger full resyncs for all the Help Centers but should be ok
There was a problem hiding this comment.
As far as I can tell the only workflow triggered by webhooks is stopIntercomSyncWorkflow -> Seems fine if we miss some
There was a problem hiding this comment.
this workflow is triggered by a webhook on /uninstall, it's clearly not fine at all if we miss some but this one is more easily reconstructible (we need the connectorId in the webhook and we're good to go)
connectors/src/connectors/intercom/temporal/sync_help_center.ts
Outdated
Show resolved
Hide resolved
| @@ -52,6 +55,11 @@ export async function intercomSyncWorkflow({ | |||
| }) { | |||
| await saveIntercomConnectorStartSync({ connectorId }); | |||
|
|
|||
| // Add folder node for teams | |||
| await upsertIntercomTeamsFolderActivity({ | |||
There was a problem hiding this comment.
exceptionally, just this once, we could discuss moving that into the syncTeamOnly activity
To be discussed with @overmode @philipperolet @aubin-tchoi vs the difficulty of stopping / restarting all intercom workflows for this change
There was a problem hiding this comment.
cc #9469 (comment) I think we can get away with batch stop + batch resume
There was a problem hiding this comment.
@aubin-tchoi says it shouldn't be a problem, I will check the code too, leaving it there until that
aubin-tchoi
deleted the
9158-kw-search-update-backfill-folders-for-intercom
branch
Description
Add folder nodes for TeamId, Teams, CollectionId and HelpCenter
Risk
Break Intercom connector
Test
Connect locally, do a few operations, delete then restore connector.
Deploy Plan
20241219_backfill_intercom_data_source_folders.ts