feat: add reasoning effort to agent config model + support in core #9603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fontanierh
force-pushed
the
feat/reasoning-effort
branch
from
95dbc9d to
f067563
Compare
tdraier
approved these changes
Dec 23, 2024
Comment on lines
5
to
10
| CREATE OR REPLACE FUNCTION perform_migration(backfilled boolean DEFAULT false) | ||
| RETURNS VARCHAR AS $$ | ||
| BEGIN | ||
| IF NOT backfilled THEN | ||
| RAISE NOTICE 'The backfill script: is required before applying this migation. If you already did it, run psql with --set=backfilled=1 argument.'; | ||
| END IF; |
There was a problem hiding this comment.
what backfill is needed for that ?
There was a problem hiding this comment.
Removed, for some reason our migration generator adds all that stuff (I never want it personally)
|
@tdraier it's the amount of test time compute you want to use for o1 models: https://platform.openai.com/docs/api-reference/chat/create |
fontanierh
added
the
migration-ack
spolu
reviewed
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reasoningEfforton theagent_configurationstable (optional)reasoning_effortconfig oncoreLLM / Chat blocks for OAI provider (asextrasconfig).Risk
critical path for pretty much everything + database migration
Deploy Plan
core(adds support for the config) and deployfront(functionally a no-op)