Delete unused icons & stroke mode #9745
Merged
+8
−3,986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinotalexandre
changed the title
|
@pinotalexandre FYI: No biggie but we usually split changes in front and sparkle into 2 different PRs, otherwise if your |
|
Don't see any problem in front-edge, ok for you if I bump a new sparkle version and then deploy sparkle? @JulesBelveze |
|
@JulesBelveze I deleted front modifications, so I guess the plan is to merge PR -> Deploy Sparkle, bump sparkle version in front in another PR? |
|
@pinotalexandre Yessir! You'll need to bump sparkle version again though (someone took 0.2.355 away from you already 👿 |
pinotalexandre
force-pushed
the
clean-icon
branch
2 times, most recently
from
4673bbc to
7499b62
Compare
pinotalexandre
force-pushed
the
clean-icon
branch
from
7499b62 to
0507922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning Sparkle - Deleting unused icons and stroke mode.
An exception has been made for "Star" that is used as a toggle button for favorite, so I moved it to the solid folder but with a different name.
Deleted theses :
Risk
Break UI
Deploy Plan
Merge PR
Deploy Sparkle