-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace uploaded file with stored one on save entity. #102
Replace uploaded file with stored one on save entity. #102
Conversation
+1 |
Nice PR. Maybe its better to move your code inside the |
I am curios what is the purpose of it?
-1. As I got |
For explanation see #8 (comment) Thats right, maybe not the best implementation, other ideas? |
Things described in #8 is not in the scope of this PR. It should definitely be another PR. I would stay with this implementation for now. |
@Baachi Are you gonna merge it? What else should be done here? |
@makasim No, i haven't the required privileges. |
@ftassi closed? is this bug is fixed in master? |
@makasim Should be fixed in master, try using it in your applications and let me know if you have any issues. |
thanks |
It fixes #34
Without this change it is not possible to use
exercise/elastica-bundle
withmapper-attachment
plugin. The uploaded file is removed on flush but the elastica bundle tries to index the file content at same time. Is there a change to get this merged?