Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI pipeline to use node >=12 #265

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Update CI pipeline to use node >=12 #265

wants to merge 3 commits into from

Conversation

Zizaco
Copy link
Contributor

@Zizaco Zizaco commented Sep 8, 2020

Motivation:

This PR aims to update the CI pipeline to replace node v8 with v12.
Currently the build fails in node 8 due to the use of the spread operator (...) in cli-engine.

/home/travis/build/duyluonglc/lucid-mongo/node_modules/eslint/lib/cli-engine/cli-engine.js:257
        ...calculateStatsPerFile(messages)
        ^^^
SyntaxError: Unexpected token ...

@Zizaco Zizaco changed the title chore(build): removed not supported node version Update CI pipeline to use node >=12 Sep 8, 2020
@Zizaco
test: improved reliability of distinct result
fe5e668 
by ensuring the order of the result before asserting
@coveralls
Copy link

coveralls commented Sep 8, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 87.739% when pulling e771029 on Zizaco:fix-build into 6377e9d on duyluonglc:develop.

@Zizaco
Copy link
Contributor Author

Zizaco commented Sep 8, 2020 •
edited
Loading

Hey @duyluonglc can you please check this out. With this PR all the test builds will go back to green ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zizaco @coveralls