Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-fuzz: set fd inheritance properly for Go 1.17+ on Windows #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

go-fuzz: set fd inheritance properly for Go 1.17+ on Windows #330

wants to merge 1 commit into from

Commits on Dec 2, 2021

  1. go-fuzz: set fd inheritance properly for Go 1.17+ on Windows 

    During Go 1.17 development, fd inheritance on Windows was changed in:
    CL 288297 - "syscall: restrict inherited handles on Windows"
    https://golang.org/cl/288297

Running go-fuzz with Go 1.17 on at least some Windows versions caused errors like:
    "write to testee failed: write |1: The pipe is being closed"

The fix is to properly set SysProcAttr.AdditionalInheritedHandles, which is modeled
after the suggestion from Jason Donenfeld in CL 320050:
    https://go-review.googlesource.com/c/go/+/320050/-1..3#message-ed1be75fda3d32c5ff2bd037b951a875cb07c3db

Fixes dvyukov#328
    thepudds committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    829e0cb View commit details
    Browse the repository at this point in the history