Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docstrings for graph relabeling and sublattice mapping functionality missing from reference documentation. #238

Merged
merged 11 commits into from
Jul 24, 2024

Conversation

qwriter
Copy link
Contributor

@qwriter qwriter commented May 27, 2024

Also, edited those docstrings.

This is the fix for issue #234.

Duplicate of #237 because accidentally created PR from main.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (0b9682b) to head (5804a5b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   75.81%   75.81%           
=======================================
  Files          31       31           
  Lines        2171     2171           
=======================================
  Hits         1646     1646           
  Misses        525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dwave_networkx/generators/chimera.py Outdated Show resolved Hide resolved
dwave_networkx/generators/chimera.py Show resolved Hide resolved
dwave_networkx/generators/chimera.py Outdated Show resolved Hide resolved
dwave_networkx/generators/chimera.py Outdated Show resolved Hide resolved
dwave_networkx/generators/chimera.py Outdated Show resolved Hide resolved
dwave_networkx/generators/zephyr.py Outdated Show resolved Hide resolved
dwave_networkx/generators/zephyr.py Show resolved Hide resolved
dwave_networkx/generators/zephyr.py Show resolved Hide resolved
dwave_networkx/generators/zephyr.py Outdated Show resolved Hide resolved
dwave_networkx/generators/zephyr.py Outdated Show resolved Hide resolved
qwriter and others added 2 commits July 11, 2024 16:59
@JoelPasvolsky
Copy link
Contributor

An advantage of doing a rebase is that you don't get commits like this one scattered through the git history.

Copy link
Contributor

@JoelPasvolsky JoelPasvolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have returned values for chimera functions but not pegasus & zephyr functions --- would be nice to have for all but I wouldn't add that to this PR.
Thanks!

dwave_networkx/generators/chimera.py Outdated Show resolved Hide resolved
dwave_networkx/generators/chimera.py Outdated Show resolved Hide resolved
dwave_networkx/generators/chimera.py Outdated Show resolved Hide resolved
dwave_networkx/generators/chimera.py Outdated Show resolved Hide resolved
dwave_networkx/generators/chimera.py Show resolved Hide resolved
dwave_networkx/generators/pegasus.py Outdated Show resolved Hide resolved
dwave_networkx/generators/pegasus.py Outdated Show resolved Hide resolved
dwave_networkx/generators/zephyr.py Outdated Show resolved Hide resolved
dwave_networkx/generators/zephyr.py Outdated Show resolved Hide resolved
dwave_networkx/generators/zephyr.py Outdated Show resolved Hide resolved
Copy link
Contributor

@JoelPasvolsky JoelPasvolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @qwriter, thank you!

@arcondello arcondello merged commit 7562973 into dwavesystems:main Jul 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants