-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed docstrings for graph relabeling and sublattice mapping functionality missing from reference documentation. #238
Fixed docstrings for graph relabeling and sublattice mapping functionality missing from reference documentation. #238
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage 75.81% 75.81%
=======================================
Files 31 31
Lines 2171 2171
=======================================
Hits 1646 1646
Misses 525 525 ☔ View full report in Codecov by Sentry. |
Implemented Joel's straightforward feedback. Co-authored-by: Joel Pasvolsky <[email protected]>
An advantage of doing a rebase is that you don't get commits like this one scattered through the git history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently have returned values for chimera functions but not pegasus & zephyr functions --- would be nice to have for all but I wouldn't add that to this PR.
Thanks!
Co-authored-by: Joel Pasvolsky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @qwriter, thank you!
Also, edited those docstrings.
This is the fix for issue #234.
Duplicate of #237 because accidentally created PR from
main
.