Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip's specs tokens are not synchro with the implementation #1610

Open
3 tasks done
GomezIvann opened this issue Jun 5, 2023 · 3 comments · Fixed by #1947
Open
3 tasks done

Chip's specs tokens are not synchro with the implementation #1610

GomezIvann opened this issue Jun 5, 2023 · 3 comments · Fixed by #1947
Assignees
Labels
guidelines inconsistency jira This task is referenced in a story of Jira non-closable This task is exempt from becoming stale or automatically closed.

Comments

@GomezIvann
Copy link
Collaborator

GomezIvann commented Jun 5, 2023

While implementing a fix for the Chip component I noticed that the tokens of the current implementation are not matching the ones established on the specifications page of the component. This is a problem since the user can get confused when, for example, creating an advanced theme.

The task here is to review all the tokens of the component and synchronize implementation with the specs page.

  • on-dark tokens do not exist in the implementation of the component anymore.

image

  • Spacing tokens are not present in the implementation.

image

  • Missing tokens on the specs page.
  chip: {
    backgroundColor: CORE_TOKENS.color_grey_200,
    disabledBackgroundColor: CORE_TOKENS.color_grey_100,
    fontFamily: CORE_TOKENS.type_sans,
    fontSize: CORE_TOKENS.type_scale_03,
    fontStyle: CORE_TOKENS.type_normal,
    fontWeight: CORE_TOKENS.type_regular,
    fontColor: CORE_TOKENS.color_black,
    disabledFontColor: CORE_TOKENS.color_grey_500,
    borderColor: CORE_TOKENS.color_transparent,
    borderRadius: "80px",
    borderThickness: CORE_TOKENS.border_width_0,
    borderStyle: CORE_TOKENS.border_solid,
    contentPaddingLeft: "16px",
    contentPaddingRight: "16px",
    contentPaddingTop: "0px",
    contentPaddingBottom: "0px",
    iconSize: "24px",
    iconSpacing: "8px",
    iconColor: CORE_TOKENS.color_grey_800,
    hoverIconColor: CORE_TOKENS.color_grey_900,
    activeIconColor: CORE_TOKENS.color_black,
    disabledIconColor: CORE_TOKENS.color_grey_500,
    focusColor: CORE_TOKENS.color_blue_600,
    focusBorderStyle: CORE_TOKENS.border_solid,
    focusBorderThickness: CORE_TOKENS.border_width_2,
    focusBorderRadius: CORE_TOKENS.border_radius_medium,
  }
@GomezIvann GomezIvann added guidelines inconsistency jira This task is referenced in a story of Jira labels Jun 5, 2023
@github-actions github-actions bot added the stale This task has no activity and will be closed within 15 days. label Feb 9, 2024
@Mil4n0r Mil4n0r removed the stale This task has no activity and will be closed within 15 days. label Feb 12, 2024
Copy link

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

@github-actions github-actions bot added the stale This task has no activity and will be closed within 15 days. label Feb 28, 2024
@Mil4n0r Mil4n0r added non-closable This task is exempt from becoming stale or automatically closed. and removed stale This task has no activity and will be closed within 15 days. labels Feb 28, 2024
@dxc-technology dxc-technology deleted a comment from github-actions bot Feb 28, 2024
@raquelarrojo raquelarrojo self-assigned this Apr 10, 2024
@raquelarrojo raquelarrojo mentioned this issue Apr 16, 2024
5 tasks
@Mil4n0r Mil4n0r removed the non-closable This task is exempt from becoming stale or automatically closed. label Apr 17, 2024
@raquelarrojo raquelarrojo reopened this Apr 18, 2024
@raquelarrojo
Copy link
Collaborator

Copy link

github-actions bot commented May 4, 2024

This issue is stale because it has been open for 15 days with no activity. If there are no further updates or modifications within the next 15 days, it will be automatically closed.

@github-actions github-actions bot added the stale This task has no activity and will be closed within 15 days. label May 4, 2024
@Mil4n0r Mil4n0r added non-closable This task is exempt from becoming stale or automatically closed. and removed stale This task has no activity and will be closed within 15 days. labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidelines inconsistency jira This task is referenced in a story of Jira non-closable This task is exempt from becoming stale or automatically closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants