Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chip specs #1947

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Update Chip specs #1947

merged 1 commit into from
Apr 16, 2024

Conversation

raquelarrojo
Copy link
Collaborator

@raquelarrojo raquelarrojo commented Apr 16, 2024 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description

  • Update Chip specs image with the change in the disabled.
  • Update Chip tokens with the ones in the Chip implementation.

Closes #1610

@raquelarrojo raquelarrojo marked this pull request as ready for review April 16, 2024 09:53
@Mil4n0r Mil4n0r self-requested a review April 16, 2024 11:42
@Mil4n0r Mil4n0r self-assigned this Apr 16, 2024
@Mil4n0r Mil4n0r merged commit e360842 into master Apr 16, 2024
4 checks passed
@Mil4n0r Mil4n0r deleted the rarrojolopez/chip-specs branch April 16, 2024 12:06
@raquelarrojo raquelarrojo mentioned this pull request Apr 18, 2024
Merged
@raquelarrojo raquelarrojo restored the rarrojolopez/chip-specs branch April 18, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mil4n0r Mil4n0r Mil4n0r approved these changes

Assignees

@Mil4n0r Mil4n0r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chip's specs tokens are not synchro with the implementation
2 participants
@raquelarrojo @Mil4n0r