-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add R support #17
Add R support #17
Conversation
I will fire this up shortly. Will you also remove this line from your PR? It removes Zeppelin's https://github.com/dylanmei/docker-zeppelin/blob/master/Dockerfile#L53 |
My first attempt to build this failed.
I notice there is no "r" module in Zeppelin's top-level pom.xml. There are however |
I will remove the line, yes. And that's confusing. But how about just using their maven-profiles? I guess they include everything Zeppelin needs. Maybe this image is even missing something we don't know? Did you compare the image-size by using maven-profiles and your way? |
Using the |
The |
Seems like they're doing something in the maven-profiles. EDIT: But it's your decision if you want the full R-support in your image. I understand if it's a decision of size for you. I want it, so i would just do a fork of your image. That's no problem! :) |
See more in #15