Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R support #17

Closed
wants to merge 4 commits into from
Closed

Add R support #17

wants to merge 4 commits into from

Conversation

BirgerK
Copy link

@BirgerK BirgerK commented Sep 17, 2016

See more in #15

@dylanmei
Copy link
Owner

I will fire this up shortly. Will you also remove this line from your PR? It removes Zeppelin's SparkR notebook/tutorial which I think we'd like to make available along with these changes.

https://github.com/dylanmei/docker-zeppelin/blob/master/Dockerfile#L53

@dylanmei
Copy link
Owner

My first attempt to build this failed.

[ERROR] Could not find the selected project in the reactor: r @ 
Could not find the selected project in the reactor: r -> [Help 1]

I notice there is no "r" module in Zeppelin's top-level pom.xml. There are however -Pr and -Psparkr, which is confusing. It seems like the direction they are going with R support is not fully worked out.

@BirgerK
Copy link
Author

BirgerK commented Sep 18, 2016

I will remove the line, yes.

And that's confusing. But how about just using their maven-profiles? I guess they include everything Zeppelin needs. Maybe this image is even missing something we don't know?

Did you compare the image-size by using maven-profiles and your way?

@dylanmei
Copy link
Owner

Using the -Pr profile brings the image from 1.69Gb to 2.47Gb. But just adding -Pr didn't make the %r interpreter available to me yet.

@BirgerK
Copy link
Author

BirgerK commented Sep 18, 2016

The %r-interpreter is "hidden" in the spark-interpreter. Beneath to spark you see a list of %-entries. On my installation %r appears there.

@dylanmei
Copy link
Owner

I must be missing something. 😕

I needed to add -Pr to get it to even build. But now that it's built I don't see the hidden %r interpreter in the spark-interpreter.

zeppeline-spark-r

@BirgerK
Copy link
Author

BirgerK commented Sep 18, 2016

Seems like they're doing something in the maven-profiles.

EDIT: But it's your decision if you want the full R-support in your image. I understand if it's a decision of size for you. I want it, so i would just do a fork of your image. That's no problem! :)

@BirgerK BirgerK closed this Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants