Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated and vulnerable dependencies #6

Merged
merged 3 commits into from
Mar 3, 2021
Merged

Update deprecated and vulnerable dependencies #6

merged 3 commits into from
Mar 3, 2021

Conversation

losuler
Copy link
Contributor

@losuler losuler commented Mar 2, 2021

I was in the process of packaging your library as a dependency for another package when I noticed it's tests were failing. There were a couple issues I discovered that I've resolved with this pull request. They were:

Both these new dependencies maintain the same MIT license, so there shouldn't be any issues in regards to that with these changes.

➜  winrmtest git:(master) go test -v  
=== RUN   Test_creating_a_shell
--- PASS: Test_creating_a_shell (0.00s)
=== RUN   Test_executing_a_command
--- PASS: Test_executing_a_command (0.00s)
=== RUN   Test_executing_a_regex_command
--- PASS: Test_executing_a_regex_command (0.00s)
=== RUN   Test_receiving_command_results
--- PASS: Test_receiving_command_results (0.00s)
=== RUN   Test_deleting_a_shell
--- PASS: Test_deleting_a_shell (0.00s)
PASS
ok  	github.com/dylanmei/winrmtest	0.005s

@dylanmei
Copy link
Owner

dylanmei commented Mar 3, 2021

Thanks!!

@dylanmei dylanmei merged commit fbc9ae5 into dylanmei:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants