fix(tokenfactory): remove denom validation upon change admin (#675)

validate basic doesn't validate denom

(cherry picked from commit 848d94f)

x/tokenfactory/bindings/message_plugin.go

@@ -259,7 +259,7 @@ func GetFullDenom(contract string, subDenom string) (string, error) {
 	if _, err := parseAddress(contract); err != nil {
 		return "", err
 	}
-	fullDenom, err := tokenfactorytypes.GetTokenDenom(contract, subDenom)
+	fullDenom, err := tokenfactorytypes.ConstructFactoryDenom(contract, subDenom)
 	if err != nil {
 		return "", sdkerrors.Wrap(err, "validate sub-denom")
 	}

x/tokenfactory/keeper/createdenom.go

@@ -77,7 +77,7 @@ func (k Keeper) validateCreateDenom(ctx sdk.Context, creatorAddr string, subdeno
 			"can't create subdenoms that are the same as a native denom")
 	}
 
-	denom, err := types.GetTokenDenom(creatorAddr, subdenom)
+	denom, err := types.ConstructFactoryDenom(creatorAddr, subdenom)
 	if err != nil {
 		return "", err
 	}

x/tokenfactory/types/denoms.go

@@ -18,10 +18,10 @@ const (
 	MaxCreatorLength = 59 + MaxHrpLength
 )
 
-// GetTokenDenom constructs a denom string for tokens created by tokenfactory
+// ConstructFactoryDenom constructs a denom string for tokens created by tokenfactory
 // based on an input creator address and a subdenom
 // The denom constructed is factory/{creator}/{subdenom}
-func GetTokenDenom(creator, subdenom string) (string, error) {
+func ConstructFactoryDenom(creator, subdenom string) (string, error) {
 	if len(subdenom) > MaxSubdenomLength {
 		return "", ErrSubdenomTooLong
 	}

x/tokenfactory/types/denoms_test.go

@@ -121,7 +121,7 @@ func TestGetTokenDenom(t *testing.T) {
 		},
 	} {
 		t.Run(tc.desc, func(t *testing.T) {
-			_, err := types.GetTokenDenom(tc.creator, tc.subdenom)
+			_, err := types.ConstructFactoryDenom(tc.creator, tc.subdenom)
 			if tc.valid {
 				require.NoError(t, err)
 			} else {

x/tokenfactory/types/msgs.go

@@ -34,7 +34,7 @@ func (m MsgCreateDenom) ValidateBasic() error {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid sender address (%s)", err)
 	}
 
-	_, err = GetTokenDenom(m.Sender, m.Subdenom)
+	_, err = ConstructFactoryDenom(m.Sender, m.Subdenom)
 	if err != nil {
 		return sdkerrors.Wrap(ErrInvalidDenom, err.Error())
 	}
@@ -188,9 +188,8 @@ func (m MsgChangeAdmin) ValidateBasic() error {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid address (%s)", err)
 	}
 
-	_, _, err = DeconstructDenom(m.Denom)
-	if err != nil {
-		return err
+	if m.Denom == "" {
+		return sdkerrors.Wrapf(sdkerrors.ErrInvalidRequest, "Denom cannot be empty")
 	}
 
 	return nil
@@ -228,11 +227,6 @@ func (m MsgSetDenomMetadata) ValidateBasic() error {
 		return err
 	}
 
-	_, _, err = DeconstructDenom(m.Metadata.Base)
-	if err != nil {
-		return err
-	}
-
 	return nil
 }