Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add events for sequencer rewards #335

Merged
merged 36 commits into from
Mar 23, 2024
Merged

chore: add events for sequencer rewards #335

merged 36 commits into from
Mar 23, 2024

Conversation

mtsitrin
Copy link
Collaborator

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin
cleanup before changes
8e72ba0
@mtsitrin
genereated new proto
b8915c8
@mtsitrin
added logic
3a4224d
@mtsitrin
starting writing tests
695fa8c
@mtsitrin
moved test app to be part of this repo
64ff826
@mtsitrin
minting UT
acb80af
@mtsitrin
renamed field
8c2444d
@mtsitrin
fixed inflation change. added UT
a25f7b8
@mtsitrin
fixed test and mint hooks
c86de44
@mtsitrin
removed readme for now
4c6b8cb
@mtsitrin
Removed epochProvisionQueries
04c6685
@mtsitrin
cleanup and fixed tests
ae4ec48
@mtsitrin
moved test app to seperate package
bf199e2
@mtsitrin
linter
293b0f0
@mtsitrin
adding annual epoch by default
eccb825
@mtsitrin
validating epoch identifiers exists
958571e
@mtsitrin
fixed init genesis order
fbc2d8f
@mtsitrin
clearing expected keepers from sequencer module
9c1282d
@mtsitrin
rollapp loads sequencers from dymint on beginBlock
e309c4c
@mtsitrin
removed sequencers tx
04797d5
@mtsitrin
more cleanup
70029e8
@mtsitrin
setting const proposer for UT
9eed0a3
@mtsitrin
renamed methods to sequencer instead of validator
25d084b
@mtsitrin
fixed dist UT
6b43ebf
@mtsitrin
fixed compilation with rollapp-evm
86d23e9
@mtsitrin
fixed linter
70a418e
@mtsitrin
add sequencer rewards event
69bc565
@mtsitrin
uncommented some validation code
edbf425
@mtsitrin
better checking for genesis block
6ad2f94
@mtsitrin
fixed linter
2d79ce3
@mtsitrin mtsitrin requested a review from a team as a code owner March 19, 2024 08:55
@omritoptix
Copy link
Contributor

@mtsitrin linter fails

Base automatically changed from refactor/sequencers_module to main March 20, 2024 10:56
danwt
danwt previously approved these changes Mar 22, 2024
View reviewed changes
x/dist/keeper/proposal_handler.go Outdated Show resolved Hide resolved
x/hub-genesis/keeper/msg_server.go Show resolved Hide resolved
@omritoptix omritoptix merged commit 80b02ec into main Mar 23, 2024
5 of 6 checks passed
@omritoptix omritoptix deleted the 51-add-events-for-sequencer-rewards branch March 23, 2024 20:40
@omritoptix omritoptix linked an issue Mar 23, 2024 that may be closed by this pull request
Add events for sequencer rewards #51
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwt danwt danwt left review comments

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add events for sequencer rewards
3 participants
@mtsitrin @omritoptix @danwt