Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add tests for module epochs #351

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

hoangdv2429
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #XXX

This PR add some tests to epochs module

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@hoangdv2429 hoangdv2429 requested a review from a team as a code owner March 28, 2024 09:38
x/epochs/types/genesis.go Show resolved Hide resolved
x/epochs/keeper/epoch.go Show resolved Hide resolved
@mtsitrin
Copy link
Collaborator

test failing

@hoangdv2429
Copy link
Contributor Author

@mtsitrin test is passing now

x/epochs/types/genesis.go Outdated Show resolved Hide resolved
@mtsitrin mtsitrin merged commit 89579d2 into dymensionxyz:main Mar 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants