Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setting default values for distribution module #379

Merged

Conversation

mtsitrin
Copy link
Collaborator

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin linked an issue Apr 14, 2024 that may be closed by this pull request
@omritoptix omritoptix marked this pull request as ready for review April 14, 2024 10:19
@omritoptix omritoptix requested a review from a team as a code owner April 14, 2024 10:19
@omritoptix omritoptix merged commit 8a566e6 into main Apr 14, 2024
7 checks passed
@omritoptix omritoptix deleted the mtsitrin/373-set-bonus_proposer_reward-to-0-by-default branch April 14, 2024 10:24
@mtsitrin mtsitrin linked an issue Apr 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set bonus_proposer_reward to 0 by default Set base_proposer_reward to 0 by default
2 participants