feat(denommetadata): Add support for providing denom-trace and creation of multiple denom-metadatas #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
previously approved these changes
Apr 17, 2024
omritoptix
requested changes
Apr 17, 2024
There was a problem hiding this comment.
@trinitys7 seems like the denom trace is gonna get generated also for non ibc denom. I suggest deducing it automatically by checking if the base starts with IBC/
|
@omritoptix I set a checking path here, if the path is empty, then it's not an IBC denom |
trinitys7
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -312,7 +309,7 @@ | |||
| app.GetSubspace(authtypes.ModuleName), | |||
| authtypes.ProtoBaseAccount, | |||
| maccPerms, | |||
| sdk.Bech32PrefixAccAddr, //Bech32MainPrefix | |||
| sdk.Bech32PrefixAccAddr, // Bech32MainPrefix | |||
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning test
omritoptix
changed the title
omritoptix
approved these changes
Apr 19, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Closes #382 and #383