-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor whitelisted_addresses #392
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,7 @@ | ||
syntax = "proto3"; | ||
package rollapp.denommetadata.types; | ||
|
||
import "gogoproto/gogo.proto"; | ||
import "denommetadata/params.proto"; | ||
|
||
option go_package = "github.com/dymensionxyz/dymension-rdk/x/denommetadata/types"; | ||
|
||
// GenesisState defines the test module's genesis state. | ||
message GenesisState { | ||
// params are all parameters for the module | ||
Params params = 1 [ (gogoproto.nullable) = false ]; | ||
} | ||
message GenesisState {} | ||
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -8,13 +8,13 @@ option go_package = "github.com/dymensionxyz/dymension-rdk/x/hub-genesis/types"; | |||||
|
||||||
// State holds the state of the genesis event | ||||||
message State { | ||||||
// is_locked is a boolean that indicates if the genesis event has occured | ||||||
bool is_locked = 1; | ||||||
|
||||||
// genesis_tokens is the list of tokens that are expected to be locked on genesis event | ||||||
repeated cosmos.base.v1beta1.Coin genesis_tokens = 2 [ | ||||||
(gogoproto.nullable) = false, | ||||||
(gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins" | ||||||
]; | ||||||
// is_locked is a boolean that indicates if the genesis event has occured | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
bool is_locked = 1; | ||||||
|
||||||
// genesis_tokens is the list of tokens that are expected to be locked on | ||||||
// genesis event | ||||||
repeated cosmos.base.v1beta1.Coin genesis_tokens = 2 [ | ||||||
(gogoproto.nullable) = false, | ||||||
(gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins" | ||||||
]; | ||||||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
syntax = "proto3"; | ||
package rollapp.sequencers.types; | ||
|
||
import "gogoproto/gogo.proto"; | ||
import "sequencers/permission.proto"; | ||
|
||
option go_package = "github.com/dymensionxyz/dymension-rdk/x/sequencers/types"; | ||
|
||
message GrantPermissionsProposal { | ||
option (gogoproto.equal) = true; | ||
option (gogoproto.goproto_getters) = false; | ||
option (gogoproto.goproto_stringer) = false; | ||
|
||
string title = 1; | ||
string description = 2; | ||
|
||
repeated AddressPermissions address_permissions = 3 | ||
[ (gogoproto.nullable) = false ]; | ||
} | ||
|
||
message RevokePermissionsProposal { | ||
option (gogoproto.equal) = true; | ||
option (gogoproto.goproto_getters) = false; | ||
option (gogoproto.goproto_stringer) = false; | ||
|
||
string title = 1; | ||
string description = 2; | ||
|
||
repeated AddressPermissions address_permissions = 3 | ||
[ (gogoproto.nullable) = false ]; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
syntax = "proto3"; | ||
package rollapp.sequencers.types; | ||
|
||
import "gogoproto/gogo.proto"; | ||
|
||
// this line is used by starport scaffolding # genesis/proto/import | ||
|
||
option go_package = "github.com/dymensionxyz/dymension-rdk/x/sequencers/types"; | ||
|
||
message AddressPermissions { | ||
option (gogoproto.equal) = true; | ||
|
||
string address = 1 [ (gogoproto.moretags) = "yaml:\"address\"" ]; | ||
// list of the module name that addresses have permission to execute msg | ||
PermissionList permission_list = 2 [ | ||
(gogoproto.moretags) = "yaml:\"permission_list\"", | ||
(gogoproto.nullable) = false | ||
]; | ||
} | ||
|
||
message PermissionList { | ||
option (gogoproto.equal) = true; | ||
|
||
repeated string permissions = 1 | ||
[ (gogoproto.moretags) = "yaml:\"permissions\"" ]; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,12 @@ service Query { | |
"/dymensionxyz/dymension-rdk/sequencers/historical_info/{height}"; | ||
} | ||
|
||
// Permissions queries the permissions for given address. | ||
rpc Permissions(QueryPermissionsRequest) returns (QueryPermissionsResponse) { | ||
option (google.api.http).get = | ||
"/dymensionxyz/dymension-rdk/sequencers/permissions/{address}"; | ||
} | ||
|
||
// Parameters queries the staking parameters. | ||
rpc Params(QueryParamsRequest) returns (QueryParamsResponse) { | ||
option (google.api.http).get = "/cosmos/staking/v1beta1/params"; | ||
|
@@ -84,6 +90,20 @@ message QueryHistoricalInfoResponse { | |
cosmos.staking.v1beta1.HistoricalInfo hist = 1; | ||
} | ||
|
||
// QueryPermissionsRequest is request type for the Query/Permissions RPC | ||
// method. | ||
message QueryPermissionsRequest { | ||
// address defines the address to query for. | ||
string address = 1; | ||
} | ||
|
||
// QueryPermissionsResponse is response type for the Query/Permissions RPC | ||
// method. | ||
message QueryPermissionsResponse { | ||
// permissions defines the permissions for the given address. | ||
string permissions = 1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to store it in KVStore, and the |
||
} | ||
|
||
// QueryParamsRequest is request type for the Query/Params RPC method. | ||
message QueryParamsRequest {} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is empty, why do we need it at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep it as it's the cosmos-sdk standard, and in case we need to store some states in the future