Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): update ibcKeeper use SequencersKeeper instead of stakingKeeper #418

Merged
merged 2 commits into from
May 12, 2024

Conversation

omritoptix
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix requested a review from a team as a code owner May 5, 2024 13:37
mtsitrin
mtsitrin previously approved these changes May 5, 2024
@mtsitrin
Copy link
Collaborator

mtsitrin commented May 5, 2024

malformed go.sum

danwt
danwt previously approved these changes May 7, 2024
@mtsitrin mtsitrin dismissed stale reviews from danwt and themself via 689236c May 12, 2024 07:19
@mtsitrin mtsitrin merged commit 312bd67 into main May 12, 2024
6 checks passed
@mtsitrin mtsitrin deleted the omritoptix/update-app-go-ibc-keeper branch May 12, 2024 07:25
omritoptix added a commit that referenced this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants