Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sequencers): whitelisted relayers #572

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat(sequencers): whitelisted relayers #572

wants to merge 14 commits into from

Conversation

keruch
Copy link
Contributor

@keruch keruch commented Oct 10, 2024

Description

ADR link https://www.notion.so/dymension/ADR-Whitelisted-Relayer-Fee-Exemption-in-Rollapp-104a4a51f86a80e8ad94c916c87deb17
Closes dymensionxyz/dymension#1226

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@keruch keruch self-assigned this Oct 10, 2024
@keruch keruch requested a review from a team as a code owner October 10, 2024 15:39
@keruch keruch marked this pull request as draft October 10, 2024 15:39
@keruch keruch force-pushed the kirill/1226-whitelisted-relayers branch from a74f418 to f40c59f Compare October 10, 2024 18:00
@keruch keruch marked this pull request as ready for review October 10, 2024 18:21
zale144
zale144 previously approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@zale144 zale144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. left a couple of questions

proto/sequencers/sequencers.proto
}

// WhitelistedRelayers is used for storing the whitelisted relater list in the state
message WhitelistedRelayers {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is because it's needed for collections, right?

x/sequencers/keeper/msg_server.go
if err != nil {
panic(err) // it must be ok because we used it to check sig
return nil, fmt.Errorf("emit event: %w", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should failing to emit event be a show stopper?

Base automatically changed from kirill/1248-sequencer-reward-addr to main October 13, 2024 06:56
@mtsitrin mtsitrin dismissed zale144’s stale review October 13, 2024 06:56

The base branch was changed.

@keruch keruch marked this pull request as draft October 15, 2024 17:13
@keruch
Copy link
Contributor Author

keruch commented Oct 15, 2024

the task is suspended until the RollApp-Hub ADR is ready.

@keruch keruch marked this pull request as ready for review October 16, 2024 15:45
@keruch
Copy link
Contributor Author

keruch commented Oct 18, 2024

the PR is ready for review once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zale144 zale144 zale144 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@keruch keruch

Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sequencer zero-fee relayer address registration
2 participants
@keruch @zale144