Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eibc): have more granularity when emitting eibc order related events #1112

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Aug 18, 2024

Description


Partially closes #845

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@zale144 zale144 self-assigned this Aug 18, 2024
@zale144 zale144 requested a review from a team as a code owner August 18, 2024 12:09
mtsitrin
mtsitrin previously approved these changes Aug 18, 2024
x/eibc/types/demand_order.go Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@VictorTrustyDev
Copy link
Contributor

utACK

x/eibc/keeper/msg_server_test.go Show resolved Hide resolved
@danwt danwt merged commit 1ec00c0 into main Aug 20, 2024
63 of 127 checks passed
@danwt danwt deleted the zale144/845-segregate-eibc-events branch August 20, 2024 14:11
@VictorTrustyDev
Copy link
Contributor

@ItzhakBokris FYI, this change will break both of our indexers.


if m.FulfillerAddress != "" {
eventAttributes = append(eventAttributes, sdk.NewAttribute(AttributeKeyFulfillerAddress, m.FulfillerAddress))
func (m *DemandOrder) GetUpdatedEvent() *EventDemandOrderFeeUpdated {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetFeeUpdatedEvent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eIBC and delayedAck redundent events
4 participants