feat(incentives): rollapp gauges upgrade handler and burn creation fee #1113
Conversation
omritoptix
changed the title
| // migrateRollappGauges creates a gauge for each rollapp in the store | ||
| func migrateRollappGauges(ctx sdk.Context, rollappkeeper *rollappkeeper.Keeper, incentivizeKeeper *incentiveskeeper.Keeper) error { | ||
| rollapps := rollappkeeper.GetAllRollapps(ctx) | ||
| for _, rollapp := range rollapps { |
There was a problem hiding this comment.
should we not skip frozen rollapps?
There was a problem hiding this comment.
I prefer not.
It doesn't really matter, as this gaguge won't be active for frozen rollapp, but it breaks the assumption of rollapp gauge for each rollapp
x/incentives/keeper/msg_server.go
Outdated
| } | ||
| return nil | ||
| return k.bk.SendCoinsFromAccountToModule(ctx, address, txfeestypes.ModuleName, sdk.NewCoins(sdk.NewCoin(feeDenom, types.CreateGaugeFee))) |
There was a problem hiding this comment.
what happens to these coins then? They stay in the module, should we burn them?
There was a problem hiding this comment.
the txfees module burns the accumulated tokens periodiocally
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
- Coverage 28.22% 25.36% -2.87%
==========================================
Files 332 496 +164
Lines 52494 97746 +45252
==========================================
+ Hits 14818 24789 +9971
- Misses 35346 69783 +34437
- Partials 2330 3174 +844 ☔ View full report in Codecov by Sentry. |
| @@ -225,99 +224,3 @@ func (suite *KeeperTestSuite) TestGaugeOperations() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func (suite *KeeperTestSuite) TestChargeFeeIfSufficientFeeDenomBalance() { | |||
There was a problem hiding this comment.
moved to msg_server_test.go
omritoptix
deleted the
mtsitrin/1083-possible-unused-code-in-incentives-module
branch
Closes #1005 , #1083, #1081
This PR:
x/incentives(usesNewGaugemethods for creation instead of.Gauge{})